ENH: prevent 'from __future__ import annotations' #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
commented
Jul 6, 2022
| # It's excluded in our pyproject.toml. | ||
|
|
||
| # BAD IMPORTS (Y044) | ||
| from __future__ import annotations # Y044 "from __future__ import annotations" has no effect in stub files. |
Contributor
Author
There was a problem hiding this comment.
Can also move it to the bad imports. I put it up there as I think __future__ imports have to be the very first import.
Collaborator
There was a problem hiding this comment.
Having it here is fine, I think.
AlexWaygood
reviewed
Jul 6, 2022
Collaborator
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Looks great! Just two nits about the docs (most of our code snippets in the docs are surrounded by backticks rather than " quotes).
Also, feel free to give yourself credit in the CHANGELOG if you like ("Contributed by Torsten Wörtwein"). Not mandatory.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #241